[omniORB] Request w/patch

[George Garvey]

On Wed, Oct 19, 2005 at 10:28:22AM +0100, Duncan Grisby wrote:
> On Saturday 8 October, George Garvey wrote:
> 
> >    We use gcc's warning against old C style casts.
> >    Please consider this patch, which changes the C casts in omniidl's
> > output to C++ casts. I'm sure I missed some, but omniORB compiles with
> > this patch.
> 
> Thanks for the patch. I don't want to completely take away the old style
> casts because omniORB still runs on some ancient compilers that require
> them. I might accept your patch if it used macros to hide what kind of
> cast it was.
> 
> There are already macros in include/omniORB4/CORBA_sysdep.h for
> const_cast and reinterpret_cast. You could add static_cast there as
> well. I think some of the casts you have changed should become
> const_casts instead of static_casts.

   Is there a part of that code which is not exercised by compiling
omniORB itself? That's how I tested it. If it is all called somewhere
within omniORB, then I caught all of the const_casts. If part isn't
exercised, you may be correct.