[omniORB-dev] omniORB: Completion of error handling

[Duncan Grisby]

On Sun, 2023-10-29 at 19:00 +0100, Markus Elfring via omniORB-dev
wrote:

> Would you like to add more error handling for return values from
> functions
> like the following?
> 
> * malloc() ⇒ GetOpenNTMounts()
>  
> https://sourceforge.net/p/omniorb/svn/6666/tree/branches/4_4/omniORB/src/tool/omkdepend/gnuwin32.c#l144
> 
> * strdup() ⇒ main()
>  
> https://sourceforge.net/p/omniorb/svn/6666/tree/branches/4_4/omniORB/src/appl/omniMapper/omniMapper.cc#l238

In general, we want omniORB to be robust against this sort of thing,
but in those two specific cases there is no need. The first is in dead
code that is never used any more; the second is in startup code for a
command line tool that will never conceivably fail.

Has your analysis found other cases in more important locations?

Duncan.

-- 
 -- Duncan Grisby --
  -- duncan at grisby.org --
   -- http://www.grisby.org --