[omniORB] It seems there is a bug in SocketCollection.cc

[Duncan Grisby]

On Sunday 18 May, "Wei Jiang" wrote:
> /omni/src/lib/omniORB/orbcore/SocketCollection.cc
> 
>   342 static void closePipe(int pipe_read, int pipe_write)
>   343 {
>   344   if (pipe_read  > 0) close(pipe_read);
>   345   if (pipe_write > 0) close(pipe_write);
>   346 }
> 
> ------------------------------------
> 
>   342 static void closePipe(int pipe_read, int pipe_write)
>   343 {
> *  344   if (pipe_read  >= 0) close(pipe_read);
> *  345   if (pipe_write >= 0) close(pipe_write);
>   346 }

Thanks. I've checked that change in. In future, it would be helpful if
you sent a proper patch made with diff -u, rather than an ad-hoc
hand-written diff.

Does any system actually use file descriptor 0 for the pipe?

Cheers,

Duncan.

-- 
 -- Duncan Grisby         --
  -- duncan at grisby.org     --
   -- http://www.grisby.org --