[omniORB] Re: Ordering of #pragma hh relative to USE_core_stub_in_nt_dll_NOT_DEFINED_*

[Andrew Miller]

Andrew Miller wrote:
> Hi,
>
> I have noticed that when pragma hh is used (e.g. as in COS), it comes 
> after the NOT_DEFINED_* defines...
>
> #ifndef  USE_core_stub_in_nt_dll
> # define USE_core_stub_in_nt_dll_NOT_DEFINED_CosEventComm
> #endif
> #ifndef  USE_dyn_stub_in_nt_dll
> # define USE_dyn_stub_in_nt_dll_NOT_DEFINED_CosEventComm
> #endif
>
>
> #include "COS_sysdep.h"
On further thought, the ordering is correct, because the point of those 
defines is to save the state from the previous header.

The problem is that if you define USE_stub_in_nt_dll (as the manual 
suggests), rather than USE_core_stub_in_nt_dll and 
USE_dyn_stub_in_nt_dll, it never gets reversed. This doesn't affect COS, 
because it explicitly defines USE_dyn_stub_in_nt_dll and 
USE_core_stub_in_nt_dll.

This could be fixed either by updating the documentation, or by adding 
similar code for USE_stub_in_nt_dll as for the other defines into 
template.py.

Best regards,
Andrew Miller