[omniORB] omniORB 3 pre1 bug report

[Christof Meerwald]

Hi!

Just a few bugs I've encountered:

omni/include/omniORB3/poa.h (line 723):
  static char* ObjectId_to_string(const ObjectId& id);
  static ObjectId* string_to_ObjectId(const char* s);
  
These declarations shouldn't be static when using namespaces.


omni/src/lib/omniORB2/orbcore/giopServer.cc (line 532,
GIOP_S::HandleRequest):
  if( pd_principal[octetlen - 1] != '\0' )

This is at least a problem for octetlen==0. Does the principal really have
to have a trailing '\0' character?


omni/src/tool/omniidl2/omniORB2_be/o2be_root.cc (line 387,
o2be_root::produce_hdr):
  s << "#ifndef __" << basename << "_hh__\n"
    << "#define __" << basename << "_hh__\n\n"

Maybe non-alphanumeric characters in basename should be escaped or converted
like it is done for the EXTERNAL_GUARDs...


bye, Christof

-- 
Don't hate yourself in the morning... sleep until noon!